Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4890 #4891

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Fix #4890 #4891

merged 2 commits into from
Feb 28, 2025
+82 −16

Conversation

Feoramund
Copy link
Contributor

@Feoramund Feoramund commented Feb 27, 2025 •
edited
Loading

Note that this change will forcibly break any usage of to_cstring with a non-optional, extra Allocator_Error return value.

Fixes #4890

@Feoramund
Fix odin-lang#4890
b2e3b34 
`strings.to_cstring` previously would not check if the buffer could
handle the extra null byte and could lead to segmentation violations
when using the resulting string in an API expecting the terminator.
@Feoramund
Add tests for new safe to_cstring
6054b92
@gingerBill gingerBill merged commit 8a8894a into odin-lang:master Feb 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String builder to_cstring is unsafe
2 participants
@Feoramund @gingerBill